Commit Graph

118 Commits

Author SHA1 Message Date
Marcel Kottmann
90fc1494d2 fix: wait for all subprocesses to terminate (fixes issue #1476) 2019-10-24 14:15:15 +02:00
Remy Sharp
5124ae9528 Merge branch 'master' of github.com:remy/nodemon
* 'master' of github.com:remy/nodemon:
  chore: adding funding file
  chore: update stalebot
  feat: add message event
  fix: disable fork only if string starts with dash
  feat: add TypeScript to default execPath (#1552)
  fix: Quote zero-length strings in arguments (#1551)
2019-05-25 19:26:24 +01:00
Remy Sharp
13afac22a3 fix: ensure signal is sent to exit event 2019-05-08 15:01:50 +01:00
Emily Marigold Klassen
20ccb623c4 feat: add message event
add event to listen to messages coming from the child's ipc events, partially implementing #1519
2019-05-01 08:05:47 +01:00
Emily Marigold Klassen
886527f1f0 fix: disable fork only if string starts with dash
fixes #1554
2019-05-01 08:05:18 +01:00
Remy Sharp
dd0b96a943 fix: rs in node@11 (#1493)
Fixes node 11's `rs` support. Somehow required that the `process.stdin` to be disconnected from the child before the stream is resumed (whereas previously it seemed that it would automatically happen…possibly a node 11 bug).

Fixes #1493
2018-12-14 17:43:18 +00:00
Remy Sharp
21e052eddf fix: upgrade pstree to remove vulnerability
Fixes #1463
Fixes #1469
Fixes #1464 

Completely removes the old method of `pstree[.remy]` and drops the event-stream vuln at the same time.
2018-11-27 08:45:11 +00:00
Aaron Jensen
521eb1e49d fix: restart on change for non-default signals (#1409) (#1430)
Fixes #1409
2018-11-05 11:23:14 +00:00
Paul "Joey" Clark
11ef298303 fix: smarter handling of exit code 2
Only exit after code 2 if it happened quickly; improve messaging (recommend `||exit 1`)

If nodemon exits _quickly_ on code 2, then it'll bail and warn. If it's after ~500ms, then it assumes that the sub-process intentionally used exit 2 (like mocha or stylelint), it won't bail and treat it as a failure (like a crash).

Props to @joeytwiddle

Fixes #496 
Fixes #627
2018-07-17 19:23:25 +01:00
Remy Sharp
25a181351f fix: send proper quit signal on ctrl-c (#1387)
Fixes #1386

Also sends the correct signal codes on exit - so instead of $?=1 on
ctrl-c, you'll see $?=130 as per http://tldp.org/LDP/abs/html/exitcodes.html
2018-07-11 12:51:35 +01:00
Remy Sharp
9bbc219fd5 fix: only hook SIGINT on boot - not at require
Fixes #1326
2018-05-05 20:16:37 +01:00
Remy Sharp
85ed19d69a fix: throwing exeception on run
Fixes #1276

Due to const being used.
2018-02-27 17:34:28 +00:00
Remy Sharp
7fb365d0cc feat: try to resolve exec in node_modules/.bin (#1275)
Fixes #1268
2018-02-27 16:44:14 +00:00
Remy Sharp
7ffd5454ed fix: windows exec resolution (#1274)
Fixes #1251
2018-02-27 16:43:20 +00:00
Remy Sharp
88954455be fix: make watch & ignore relative (#1253)
* docs: add sponsors

[skip ci]

* fix: make watch & ignore relative

Fixes #1246

* fix: relative parent watching and ignore

* chore: lint

* test: fix bail on options
2018-02-15 21:57:47 +00:00
Remy Sharp
5e88b04eaa feat: add support for --spawn (#1249)
* docs: add sponsors

[skip ci]

* feat: add support for `--spawn`

Fixes #1245

* docs: remove "simply"
2018-02-15 21:57:30 +00:00
Remy Sharp
33fa6f4970 fix: wrongly normalizing slashes in windows
This change takes code from npm's cli to change the way the arguments
passed to nodemon are interpreted.

Removes path.normalize and replaces with windowsVerbatimArguments

Fixes #1236
2018-02-01 22:47:56 +00:00
Remy Sharp
4cfd0b9cf8 chore: fix lint warning 2018-02-01 22:47:41 +00:00
Remy Sharp
79e61f00e7 fix: sniff for child.stdout before using it
This fixes node@6.0.0, but it's a hack, so I'm going to emit a message
saying that non-LTS is not supported.
2018-02-01 22:47:41 +00:00
Remy Sharp
e90f15aa8a fix: node < 6.4.0 causing crash on 'rs' trigger
* fix: node < 6.4.0 can't connect to stdin
* fix: child stdio when spawn is similar to fork

Fixes #1218
2018-01-09 13:18:08 +00:00
Remy Sharp
c121187611 refactor: indexOf > includes (in node4) 2018-01-08 12:33:51 +00:00
Remy Sharp
6e7ce4bbe2 fix: swallow child.stdin err
This is a weird case where stdin isn't fully connected and throws in
ubuntu 16.04 (replicated in a Docker image).

Fixes #1195
2017-12-31 19:47:16 +00:00
Remy Sharp
0d9a89241c fix: don't use fork with node inspect
Fixes: #1191
2017-12-29 11:07:04 +00:00
Remy Sharp
5a914cb35b fix: handle exit(2) better 2017-12-29 10:55:12 +00:00
Remy Sharp
1d88943394 fix: pass stdin to child process on -I
Fixes #1036 - the no-stdin wasn't passing the process.stdin to the
child.
2017-12-20 23:21:06 +00:00
Remy Sharp
d15cf686f7 fix: remove scoped dep
Fixes #1180
2017-12-20 14:09:03 +00:00
Remy Sharp
1171fc1a9a fix: nodemon reporting crash
Fixes #1173
2017-12-16 01:17:47 +00:00
Remy Sharp
e9129c03f8 fix: switch to killing using numericals
Fixes #956
Fixes #813
2017-12-15 15:05:20 +00:00
Remy Sharp
bf9b7a6876 fix: if no ps, walk /proc to kill child fully
Originally used ps-tree which relied on `ps` on *nix. But if the system
didn't have `ps` at all, we'd try to kill the child process, but alas
this would not always work, as we're spawning `sh` and _then_ node, so
the kill would only kill the `sh` process, and not the running node
process.

The new @remy/pstree lib sniffs for `ps` and defers to ps-tree,
otherwise it will walk /proc and map the PPID to the child process
allowing nodemon to fully clean up.
2017-12-15 14:14:26 +00:00
Remy Sharp
fd961d6053 fix: defensive check on accessing cmd.args 2017-12-13 22:17:13 +00:00
Remy Sharp
d9e93ad367 fix: support node arguments again
If node is being passed any arguments (before the script) then use
spawn instead of fork.

Fixes #1161
2017-12-13 21:08:33 +00:00
Remy Sharp
f52615c0f7 fix: only use fork if node>4 2017-12-13 13:08:05 +00:00
Timothy Huang
cf923a8a77 fix: get tests to pass 2017-12-06 14:45:17 -08:00
Tim
f711fb7889 test: fork child node processes 2017-12-06 14:45:10 -08:00
Remy Sharp
6a4fb22602 fix: pass through execArgs from config (#1142)
* fix: pass through execArgs from config

Also updating some deps and linting tweaks

* chore: add message on postinstall

Lost funds from gratipay and codesponsor 😢
2017-12-05 18:01:55 +00:00
GerA
469fa80aa7 fix: crash when passing argument to node (windows)
Fixes #1095
2017-09-15 07:40:25 +01:00
Brian Dentino
facc8cb2c7 fix: exit with code 1 on crash if --exitcrash (#946)
I'm using nodemon in a docker container with a restart policy configured to restart the container in case it crashes. If the app crashes, nodemon exits with code 0 and docker assumes it was a graceful exit, so it does not restart my container. I don't see the harm in changing the exit code here to reflect an unexpected termination, given that this path is only exercised in the event of a crash.
2017-09-04 20:16:40 +01:00
Attila Hajdrik
481dc8f8ef fix: executable path handling under windows (#962)
- If the user configured a *nix compatible npm script where the path contained a forward slash, that failed under windows, since cmd.exe treated that as a command line argument.
- The quote handling was not 100% correct under windows, the whole path needs to be quoted, not just the segments it is also modified.
2017-09-04 19:47:52 +01:00
Marc Trudel
2cd85b1f60 feat: add support for customisable signal 2016-10-06 19:52:41 +01:00
Remy Sharp
be5d4e8d13 fix: revert 'inherit' on stdin
Fixes #894
Fixes #895

I'll have to continue investigation as to how we deal with spawned clients setting raw on stdin. Will break #890 and https://github.com/FormidableLabs/webpack-dashboard/issues/16
2016-08-18 22:04:42 +01:00
Remy Sharp
58a236e0ce fix: use stdin=inhert on vanilla run
* fix: non-utf8 stdin processing
Fixes #890
Ref https://github.com/FormidableLabs/webpack-dashboard/issues/16

The library blessed inside of the webpack-dashboard does some funky stuff with std streams and the expectation of the encoding. I'm not 100% sure of this change, I've got to see all the tests, but this tweak moves to inherit the child's stdin and doesn't purposely encode the stdin stream as utf8 (which, I don't recall exactly why I did this in the first place…though I'm fairly sure it was another issue somewhere else in nodemon).
* fix: use stdin:inherit when we're not forked
* fix: don't use inherit when required
* style: lint
* style: I am going to 🐎 kick the lint in the 🌰
2016-08-18 15:54:39 +01:00
Remy Sharp
8a0ce0941f fix: rs to restart
Always unhook the process.stdin when the child has exited, this allows the `rs` command to be read - otherwise it's ignored.

Fixes #648
2015-10-19 12:27:53 +01:00
Remy Sharp
a3b6c3ec26 fix: allows user to not watch
Fixes #516
2015-10-19 12:27:53 +01:00
Remy Sharp
29cf71e979 fix: stdin was closed after crashed child
Fixes #601
2015-10-19 12:27:53 +01:00
Remy Sharp
03ef996d29 chore: Merge branch 'fix/package-start-with-env' 2015-09-19 10:25:50 +01:00
Kevin Woo
cde21fb4de test: added dotfile tests 2015-09-15 21:46:36 -07:00
Remy Sharp
5e07bfef85 fix: supporting env values in package.start
Before it was trying to parse the value in .start, when in fact, the entire value represents the `cmd`.

Fixes #621
Fixes #615
Fixes #577
Fixes #513
2015-09-12 22:51:02 +01:00
Remy Sharp
f7a94768f6 refactor: add debugging 2015-09-10 10:38:32 +01:00
Remy Sharp
438b8d7c0e refactor: passing jscs 2015-09-09 22:30:43 +01:00
Remy Sharp
7496f08330 fix: incorrectly exiting when required
test: updated travis tests
2015-09-09 22:29:26 +01:00