Commit Graph

77 Commits

Author SHA1 Message Date
Remy Sharp
8a0ce0941f fix: rs to restart
Always unhook the process.stdin when the child has exited, this allows the `rs` command to be read - otherwise it's ignored.

Fixes #648
2015-10-19 12:27:53 +01:00
Remy Sharp
a3b6c3ec26 fix: allows user to not watch
Fixes #516
2015-10-19 12:27:53 +01:00
Remy Sharp
29cf71e979 fix: stdin was closed after crashed child
Fixes #601
2015-10-19 12:27:53 +01:00
Remy Sharp
03ef996d29 chore: Merge branch 'fix/package-start-with-env' 2015-09-19 10:25:50 +01:00
Kevin Woo
cde21fb4de test: added dotfile tests 2015-09-15 21:46:36 -07:00
Remy Sharp
5e07bfef85 fix: supporting env values in package.start
Before it was trying to parse the value in .start, when in fact, the entire value represents the `cmd`.

Fixes #621
Fixes #615
Fixes #577
Fixes #513
2015-09-12 22:51:02 +01:00
Remy Sharp
f7a94768f6 refactor: add debugging 2015-09-10 10:38:32 +01:00
Remy Sharp
438b8d7c0e refactor: passing jscs 2015-09-09 22:30:43 +01:00
Remy Sharp
7496f08330 fix: incorrectly exiting when required
test: updated travis tests
2015-09-09 22:29:26 +01:00
Remy Sharp
b0fd56f7de refactor: move watch out in favour of chokidar
Plus jscs clean ups
2015-08-31 18:25:55 +01:00
Remy Sharp
e177dd7865 Merge pull request #578 from khoomeister/ck-disable-startup
add option --no-startup to not run command on startup
2015-07-27 21:44:05 +01:00
Zolmeister
e89786388c monitor: always exit, fixes #592 2015-07-26 00:57:13 -07:00
Chris Khoo
50f5994ee6 change --no-startup to --on-change-only 2015-07-20 18:40:45 -07:00
Chris Khoo
db196733b7 add option --no-startup to not run command on startup 2015-07-05 16:19:11 -07:00
Remy Sharp
01bc4d0ba1 Merge pull request #515 from STRML/fixQuit
Fix nodemon.json's 'quit' listener and add test.
2015-05-19 13:28:22 +01:00
Doug Patti
56c4caf2ed pull command stringification into a utility
This was copied and pasted more than a handful of times around the
library and tests. Some implementations were more naive and did not
try to add quotes if there are spaces within a single argument.

There is one slight oddity in one of the cli parse tests. Stringifying
the command causes many of the arguments to show up in quotes when they
probably shouldn't. This seems to trace back to a deep problem related
to how commands are pulled out of package.scripts.start and is out of
scope for this patch. Even though the test might look incorrect now, it
is an accurate reflection of what the generated command is.
2015-04-22 13:42:55 -04:00
Samuel Reed
15751fe432 Fix nodemon.json's 'quit' listener and add test. 2015-03-02 18:44:21 +07:00
Remy Sharp
47896d9254 Fix the pattern match for windows escaping
Fixes #497
2015-02-11 15:04:31 +00:00
Remy Sharp
d984c473a2 Merge pull request #502 from remy/fix/node-0-12
Fixed #499 [skip ci]
2015-02-11 12:32:17 +00:00
Remy Sharp
10ed83ea21 Fixed #499
`rs` now works again on windows when app has crashed.
2015-02-11 12:16:16 +00:00
Remy Sharp
7e6fe7c945 Fixes #352
The find method wasn't known when it tries to add the directories to monitor. This change fixes that
2015-02-10 19:22:40 +00:00
Remy Sharp
afc646f026 Fixed #474
Support spaces in exec - the user must escape using the ^ character as per http://superuser.com/a/279121
2015-01-28 13:27:21 +00:00
tom
df006c96a7 parse cmd.args 2015-01-22 11:56:03 +08:00
Remy Sharp
51f825d341 Add test to check if passed opts are priority
Currently failing due to bug in code - THIS IS MY PLAN!
2015-01-20 14:08:11 +00:00
Remy Sharp
3feff5035e Fixed #468
My old spawn check was based on the minor value being >= 8, of course now io.js is 1.0.2, it wasn't using the new spawn method, and silencing user scripts.
2015-01-19 21:58:49 +00:00
Remy Sharp
9651ab88b0 Escape exec *args* only if space
This matches npm's functionality. It's also been tested against the "some\"file" test, etc. It's hard too...and late.
2015-01-14 22:45:45 +00:00
Remy Sharp
5f7f36c562 Fixed #454
Detect if `ps` is available, and if not, just try to kill the parent
2015-01-07 22:03:24 +00:00
Remy Sharp
b905ffae7d Fixed #448 - but failing other tests WIP
[skip ci]

Currently failing tests around handling of spaces in exec arguments.
2015-01-01 21:39:10 +00:00
Remy Sharp
c85943b76d WIP 2015-01-01 21:26:49 +00:00
Remy Sharp
da72f41e46 Fixed windows support
Except windows shutdown before I had a chance run npm test - but it work!
2014-12-09 17:09:52 +00:00
Remy Sharp
f7537533dd Use sh to spawn, allowing for complex commands
Pinched from https://github.com/npm/npm/blob/master/lib/utils/lifecycle.js#L197

By switching to using `sh` to fire up the command, it allows the user's exec command to chain unix commands together.
2014-12-09 16:26:25 +00:00
Remy Sharp
93113c9d70 Better tests for scripts with spaces 2014-12-08 18:31:25 +00:00
Remy Sharp
734986de19 Shouldn't be using strict equality 2014-12-06 15:17:49 +00:00
Remy Sharp
96bd4b3e79 Fixed tests on Mac
Specifically race conditions where the child process was being left running still
2014-12-04 22:07:34 +00:00
Remy Sharp
7b2b96bf8b Don't echo when we're done 2014-12-02 13:04:36 +00:00
Remy Sharp
6deafd63a4 Cleanly remove timers on exit sig 2014-12-02 13:04:36 +00:00
Remy Sharp
4b9fd2edf1 Fix #370
Check that the child is not undefined before trying to kill
2014-07-20 06:59:38 +01:00
Remy Sharp
51af999349 Fix #355
Very sutble, but ensures that we kill the child *before* the stdin connection is closed. This is because (for this particular bug) the child was listening to stdin.end and self terminating, which meant that our SIGUSR2 signal never made it to the child, which results in nodemon not realising that the child should be restarted. Hopefully this helps others too!
2014-07-01 16:56:31 +01:00
Michael Heuberger
c4e263ed37 expose streams for piping (mh) 2014-06-04 02:49:24 +12:00
Remy Sharp
8647107eb5 Merge pull request #338 from remy/fix/kill-subtree
Ensure *nix kills entire process tree.
2014-05-13 08:00:09 +01:00
Remy Sharp
4d1dc59ce0 Tests for subtree nukage. 2014-05-13 00:04:04 +01:00
Remy Sharp
1f2ca59317 Ensure only subtree of child is killed
Otherwise when nodemon is required in, it could accidently kill children of the parent process that nodemon shouldn't really be touching.
2014-05-12 23:33:15 +01:00
Remy Sharp
7901854408 Ensure *nix kills entire process tree.
Fixes #333 and fixes #335. Amazingly Windows support always had the full process tree being killed, but this solves it for mac and linux now. My only grip is we have a new dependancy for the project, but I don't really think that's such a big deal.
2014-05-12 22:41:26 +01:00
Remy Sharp
59a5851552 fixed #289. setTimeout to the rescue? 2014-04-04 10:50:57 +01:00
Remy Sharp
690c564a80 Fixed #303, #304 and #311.
We don't use pipe by default for stdio spawn, we look at how nodemon is being used, the either decide to use pipe or process.stdout/err. Then depending on whether nodemon is required, we then attach to the different stdout/err streams as required.
2014-03-20 12:08:48 +00:00
Remy Sharp
a9f8dd97ec Work on #304 and #304 to read the stdout *stream*
Changed it from using `.on('data')` to using a PassThrough stream which does the job much better, but the readline demos don't work when they're doing anything special on stdout, like `.cursorTo`. WIP.
2014-03-19 14:27:03 +00:00
Remy Sharp
2a2f1260e4 If no script, default is null, not -1. Fixes #265
Includes test and exposing the command run for debugging.
2014-01-21 07:57:27 +00:00
Remy Sharp
f636bc16f5 execMap uses script ext to lookup. Fixes #265
+ tests
2014-01-16 22:52:39 +00:00
Remy Sharp
483e70283e Pass non-nodemon args *in order* to exec. Fixes #263 2014-01-15 14:11:56 +00:00
Remy Sharp
bfc4ac1c4d Required nodemon accepts env to pass to spawned process
See https://github.com/ChrisWren/grunt-nodemon/pull/29 for example/request
2014-01-15 14:07:36 +00:00