From 84a9f6f8bd1e5a12a5c391649c95985a99ca9713 Mon Sep 17 00:00:00 2001
From: Izan Gil <66965250+SrIzan10@users.noreply.github.com>
Date: Tue, 10 Feb 2026 19:40:42 +0100
Subject: [PATCH] fix: macos screen capture prompt

---
 app/composables/useElectron.ts | 26 +++++++++++++++++++++++++-
 app/pages/stream.vue           | 32 ++++++++++++++++++++++++++++++++
 electron/main/index.ts         | 15 +++++++++++++++
 electron/preload/index.ts      |  2 ++
 i18n/locales/en.json           |  5 ++++-
 i18n/locales/es.json           |  5 ++++-
 6 files changed, 82 insertions(+), 3 deletions(-)

diff --git a/app/composables/useElectron.ts b/app/composables/useElectron.ts
index 73eb2cb..aa67f7d 100644
--- a/app/composables/useElectron.ts
+++ b/app/composables/useElectron.ts
@@ -36,6 +36,7 @@ interface HeliumElectronAPI {
   venmicLink: (options: VenmicLinkOptions) => Promise<boolean>;
   venmicUnlink: () => Promise<boolean>;
   checkScreenPermission: () => Promise<string>;
+  openScreenPermissionSettings: () => Promise<boolean>;
 }
 
 declare global {
@@ -212,6 +213,28 @@ export function useElectron() {
     return platformInfo.value.supportsLoopbackAudio || platformInfo.value.supportsVenmic;
   });
 
+  const getScreenPermissionStatus = async (): Promise<string> => {
+    if (!checkElectron()) return "granted";
+
+    try {
+      return await window.heliumElectron!.checkScreenPermission();
+    } catch (error) {
+      console.error("[useElectron] Failed to check screen permission:", error);
+      return "unknown";
+    }
+  };
+
+  const openScreenPermissionSettings = async (): Promise<boolean> => {
+    if (!checkElectron()) return false;
+
+    try {
+      return await window.heliumElectron!.openScreenPermissionSettings();
+    } catch (error) {
+      console.error("[useElectron] Failed to open screen permission settings:", error);
+      return false;
+    }
+  };
+
   onMounted(() => {
     checkElectron();
     if (isElectron.value) {
@@ -246,9 +269,10 @@ export function useElectron() {
     linkAllAudio,
     linkAppAudio,
     unlinkVenmicAudio,
+    getScreenPermissionStatus,
+    openScreenPermissionSettings,
 
     startScreenShareWithAudio,
     stopScreenShare,
   };
 }
-
diff --git a/app/pages/stream.vue b/app/pages/stream.vue
index 45a25a2..37b5be0 100644
--- a/app/pages/stream.vue
+++ b/app/pages/stream.vue
@@ -56,6 +56,7 @@
 
 <script setup lang="ts">
 import { useWebSocket } from "@vueuse/core";
+import { toast } from "vue-sonner";
 import { Button } from "@/components/ui/button";
 import { Switch } from "@/components/ui/switch";
 import { Label } from "@/components/ui/label";
@@ -66,6 +67,7 @@ import { useElectron } from "~/composables/useElectron";
 import PresetSelect from "~/components/app/PresetSelect.vue";
 
 const streamerStore = useStreamerStore();
+const { t } = useI18n();
 const videofeedRef = ref<HTMLVideoElement | null>(null);
 const localStream = ref<MediaStream | null>(null);
 const wsUrl = useWebSocketUrl();
@@ -83,6 +85,8 @@ const {
   linkAllAudio,
   linkAppAudio,
   unlinkVenmicAudio,
+  getScreenPermissionStatus,
+  openScreenPermissionSettings,
 } = useElectron();
 
 onMounted(async () => {
@@ -231,6 +235,7 @@ async function startScreenShare() {
     );
   } catch (error) {
     console.error("Failed to start screen share:", error);
+    await handleScreenShareError(error);
     cleanupStreaming();
   }
 }
@@ -293,9 +298,36 @@ async function changeScreenShareSource() {
     }
   } catch (error) {
     console.error("Failed to change screen share source:", error);
+    await handleScreenShareError(error);
   }
 }
 
+async function handleScreenShareError(error: unknown): Promise<void> {
+  const isPermissionDeniedError =
+    error instanceof DOMException && error.name === "NotAllowedError";
+
+  if (!isPermissionDeniedError || !isElectron.value || !platformInfo.value?.isMac) {
+    toast.error(t("failedToStartScreenShare"));
+    return;
+  }
+
+  const permissionStatus = await getScreenPermissionStatus();
+
+  if (permissionStatus === "granted") {
+    toast.error(t("failedToStartScreenShare"));
+    return;
+  }
+
+  const openedSettings = await openScreenPermissionSettings();
+
+  if (openedSettings) {
+    toast.error(t("screenRecordingPermissionRequired"));
+    return;
+  }
+
+  toast.error(t("screenRecordingPermissionRequiredNoShortcut"));
+}
+
 async function cleanupStreaming() {
   if (localStream.value) {
     localStream.value.getTracks().forEach((track) => {
diff --git a/electron/main/index.ts b/electron/main/index.ts
index 1958aa0..72e403a 100644
--- a/electron/main/index.ts
+++ b/electron/main/index.ts
@@ -4,6 +4,7 @@ import {
   ipcMain,
   desktopCapturer,
   session,
+  shell,
   systemPreferences,
   type IpcMainInvokeEvent,
   type DesktopCapturerSource,
@@ -208,6 +209,20 @@ ipcMain.handle('helium:check-screen-permission', () => {
   return 'granted';
 });
 
+ipcMain.handle('helium:open-screen-permission-settings', async () => {
+  if (!isMac) {
+    return false;
+  }
+
+  try {
+    await shell.openExternal('x-apple.systempreferences:com.apple.preference.security?Privacy_ScreenCapture');
+    return true;
+  } catch (error) {
+    console.error('[Helium] Failed to open macOS screen recording settings:', error);
+    return false;
+  }
+});
+
 const gotTheLock = app.requestSingleInstanceLock();
 
 if (!gotTheLock) {
diff --git a/electron/preload/index.ts b/electron/preload/index.ts
index a3653fb..df165e0 100644
--- a/electron/preload/index.ts
+++ b/electron/preload/index.ts
@@ -57,6 +57,8 @@ const heliumElectronAPI = {
   venmicUnlink: (): Promise<boolean> => ipcRenderer.invoke('helium:venmic-unlink'),
 
   checkScreenPermission: (): Promise<string> => ipcRenderer.invoke('helium:check-screen-permission'),
+  openScreenPermissionSettings: (): Promise<boolean> =>
+    ipcRenderer.invoke('helium:open-screen-permission-settings'),
 };
 
 contextBridge.exposeInMainWorld('heliumElectron', heliumElectronAPI);
diff --git a/i18n/locales/en.json b/i18n/locales/en.json
index b8b4c4f..68dc59b 100644
--- a/i18n/locales/en.json
+++ b/i18n/locales/en.json
@@ -59,5 +59,8 @@
   "audioSource": "Audio Source",
   "allSystemAudio": "All System Audio",
   "refreshSources": "Refresh Sources",
-  "audioSupported": "Audio Supported"
+  "audioSupported": "Audio Supported",
+  "failedToStartScreenShare": "Failed to start screen share.",
+  "screenRecordingPermissionRequired": "macOS blocked screen capture. Allow Helium in System Settings > Privacy & Security > Screen Recording, then restart Helium.",
+  "screenRecordingPermissionRequiredNoShortcut": "macOS blocked screen capture. Open System Settings > Privacy & Security > Screen Recording, allow Helium, then restart Helium."
 }
diff --git a/i18n/locales/es.json b/i18n/locales/es.json
index 6111eb9..87f578f 100644
--- a/i18n/locales/es.json
+++ b/i18n/locales/es.json
@@ -59,5 +59,8 @@
   "audioSource": "Fuente de audio",
   "allSystemAudio": "Todo el audio del sistema",
   "refreshSources": "Actualizar fuentes",
-  "audioSupported": "Audio soportado"
+  "audioSupported": "Audio soportado",
+  "failedToStartScreenShare": "No se pudo iniciar el uso compartido de pantalla.",
+  "screenRecordingPermissionRequired": "macOS bloqueó la captura de pantalla. Permite Helium en Configuración del Sistema > Privacidad y seguridad > Grabación de pantalla y luego reinicia Helium.",
+  "screenRecordingPermissionRequiredNoShortcut": "macOS bloqueó la captura de pantalla. Abre Configuración del Sistema > Privacidad y seguridad > Grabación de pantalla, permite Helium y luego reinicia Helium."
 }