sern/handler
1
0
Fork 0
mirror of https://github.com/sern-handler/handler synced 2026-06-06 01:16:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

decide not to support error handling for autocomplete

Browse Source
This commit is contained in:
jacob
2023-11-02 14:19:43 -05:00
parent 2b07bcc661
commit 17eb701b5f
2 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/handlers/dispatchers.ts
View File

@@ -83,15 +83,12 @@ export function createDispatcher(payload: {
option,
Error(SernError.NotSupportedInteraction + ` There is no autocomplete tag for this option`),
);
const { command, name, parent } = option;
const resolvedErrorHandler = parent
? 'option:'+parent+':'+name
: 'option:'+name
const { command } = option;
return {
...payload,
module: command as Processed<Module>, //autocomplete is not a true "module" warning cast!
args: [payload.event],
onError: payload.onError?.[resolvedErrorHandler]
onError: undefined
};
}
return {

12
src/handlers/event-utils.ts
View File

@@ -27,7 +27,7 @@ import { CommandError, Emitter, ErrorHandling, Logging, ModuleManager } from '..
import { contextArgs, createDispatcher } from './dispatchers';
import { ObservableInput, pipe } from 'rxjs';
import { SernEmitter } from '../core';
import { Err, Ok, Result } from 'ts-results-es';
import { Err, ErrImpl, Ok, Result } from 'ts-results-es';
import type { AnyFunction, Awaitable } from '../types/utility';
import type { ControlPlugin } from '../types/core-plugin';
import type { AnyModule, CommandModule, Module, OnError, Processed } from '../types/core-modules';
@@ -159,7 +159,7 @@ export function executeModule(
args
}: ExecutePayload,
) {
const onError$ = (err) => {
const onError$ = (err_msg: unknown) => {
if(!onError) {
return throwError(() => SernEmitter.failure(module, err));
}
@@ -177,12 +177,12 @@ export function executeModule(
const apiObject = args[0];
assert(apiObject && typeof apiObject === 'object', "Args[0] was falsy while trying to create onError");
assert(err.body, "Body of error response cannot be empty");
if('respond' in apiObject && typeof apiObject.respond === 'function') {
return throwError(() => SernEmitter.failure(module, "Cannot handle autocomplete errors"));
}
if('reply' in apiObject && typeof apiObject.reply === 'function') {
return from(apiObject.reply(err.body))
}
if('respond' in apiObject && typeof apiObject.respond === 'function') {
return from(apiObject.respond(err.body))
}
}
return EMPTY;
}